#181 · Enforce the green core — flip the test gate to blocking
Last checked with GitLab: . Status comes from GitLab using a 2-minute cache. Merge events clear affected cached statuses. An already-open page does not update itself. Refresh page.
An MR completes this bounty when it is merged into main with Closes #181 and GitLab closes the issue. A mention or an updated timestamp is not completion. Awarded points appear in Activity.
cp .dev.vars.example .dev.vars && pnpm dev, after rebasing on main) and fully test your change before opening the MR.
Description
Problem
The test job from #179 runs non-blocking (allow_failure: true) during the observe phase. A non-blocking gate gathers signal but protects nothing — a regression in a green-core suite still merges.
Goal
Once #179 has soaked and is reliably green on the runner, flip the test job to blocking (allow_failure: false). From this point the green-core suites (event-service, career-board, community-portal, scoreboard, wiki, shared-utils, + uxs-data if #180 landed) block merges.
Change
- allow_failure: true # Phase 0: observe only
+ allow_failure: false # Phase 1: blocking gate
(Quarantined suites stay excluded — this issue does not widen coverage, only enforces the already-green set.)
How to verify (branch-tested)
- Branch + MR. Confirm the
testjob is required (a forced failure in a green-core suite blocks - Confirm quarantined suites are still excluded and do not affect merge status.
the MR; reverting it unblocks).
Acceptance criteria
- [ ]
testjob isallow_failure: false. - [ ] A failing green-core test blocks the MR; quarantined suites do not.
Rollback
Revert the one-line change back to allow_failure: true if the runner proves flaky.
Depends on #179 (soaked). Independent of the app-suite-fix issues (#180/#182).
Relevant files
No relevant files linked yet.
Hints
No hints yet.
Activity
No points have been awarded for this bounty yet.
Comments
Sign in to join the discussion.
No comments yet. Be the first to weigh in.