#132 · Extract !job handlers from command-handler.ts (~800 lines)
Last checked with GitLab: . Status comes from GitLab using a 2-minute cache. Merge events clear affected cached statuses. An already-open page does not update itself. Refresh page.
An MR completes this bounty when it is merged into main with Closes #132 and GitLab closes the issue. A mention or an updated timestamp is not completion. Awarded points appear in Activity.
cp .dev.vars.example .dev.vars && pnpm dev, after rebasing on main) and fully test your change before opening the MR.
Description
Background
\!job post\, \!jobs\, \!job edit\, \!job close\ (and the multi-role split logic that surfaced the May 12 silent-skip incident) live in command-handler.ts around lines 26500-27300. Approximately 800 lines + the OpenAI parsing helper (\parseJobPosting\ is in \utils/job-parser.ts\ — leave there).
Career-board worker side is already clean (uses createLogger, dedicated client in \packages/shared-utils/src/bot-utils/career-board-client.ts\). The Signal-bot side is what's left.
Scope
- New file \
apps/signal-bot/src/src/bot/commands/community/jobs.ts\(~800 lines) - Handlers: \
handlePostJob\, \handlePostJobNaturalLanguage\, \handleListJobs\, \handleJobsExpanded\(or equivalents — confirm via grep) - \
JobDeps\interface: \{ bot, dbClient, openai, formatForSignal: import-direct, isAdmin, getRoomSettings, awardScoreboardPoints (callback) }\ - The complex multi-role parent/child job linking flow stays intact — that's where the dice/RPS extraction lessons (preserving runtime behavior exactly) matter most
Notes from session history
- v5.13.4 \
getBotApiKey()\already centralizes the auth (no more silent-skip) - The \
requireEnv('CAREER_BOARD_API_KEY')\calls have been replaced with \botAuthHeaders(process.env.CAREER_BOARD_API_KEY)\(see commit 04b97e99 + follow-up). Don't re-introduce. - Smart-route group selection + announcement dispatch lives in \
apps/career-board/src/api/announcements.ts\— bot side just kicks off the worker via the helper.
Acceptance
- All \
!job\-family handlers extracted to \commands/community/jobs.ts\ - command-handler.ts drops ~800 lines
- The May 12 incident pattern (
Career board API error (401)) is impossible to reintroduce because the extracted code consumes \getBotApiKey\from the helper - Typecheck + lint green
Bounty: M
Smaller than breakouts/QA but touches the highest-business-value command (recruiting flow). Test the full \!job post\ → multi-role split → parent/child linking flow end-to-end before merging.
Getting Started (added for pickup-readiness)
Path note: code lives under selfhost/messaging-apps/signal-messenger/src/src/bot/.
- Target file:
selfhost/messaging-apps/signal-messenger/src/src/bot/commands/community/jobs.ts; - Preserve exactly:
getBotApiKey/botAuthHeadersusage (never reintroduce - Verify:
pnpm turbo typecheck+ signal-bot lint; end-to-end test
leave parseJobPosting in utils/job-parser.ts.
requireEnv('CAREER_BOARD_API_KEY')) and the multi-role parent/child linking flow — where the May 12 silent-skip lived.
!job post → multi-role split → parent/child linking before merge.
Prepared for pickup by 🤖 GearSmith's Goal-Tender (Claude).
Relevant files
No relevant files linked yet.
Hints
No hints yet.
Activity
No points have been awarded for this bounty yet.
Comments
Sign in to join the discussion.
No comments yet. Be the first to weigh in.